Arrange and add missing keys for cy locales #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmzasif
changed the title
sunny
reviewed
Feb 13, 2024
rails/locale/cy.yml
Outdated
| one: Atalwyd y %{model} hwn rhag ei gadw gan 1 nam | ||
| two: Atalwyd y %{model} hwn rhag ei gadw gan %{count} nam | ||
| few: Atalwyd y %{model} hwn rhag ei gadw gan ychydig nam |
There was a problem hiding this comment.
Shouldn’t this still have the count variable?
Suggested change
| few: Atalwyd y %{model} hwn rhag ei gadw gan ychydig nam | |
| few: Atalwyd y %{model} hwn rhag ei gadw gan %{count} nam |
sunny
approved these changes
Feb 13, 2024
You are welcome, I have added it. |
pama
reviewed
Feb 13, 2024
CHANGELOG.md
Outdated
| @@ -17,6 +17,7 @@ | |||
| - Portuguese (pt-BR): am/pm | |||
| - Romanian (ro): am/pm | |||
| - Swedish (sv sv-FI sv-SE): am/pm | |||
| - Welsh (cy): Move the keys to rught place and add missing keys | |||
There was a problem hiding this comment.
There is small typo here "rught" should "right"
There was a problem hiding this comment.
Sorry for it; it's already been fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the error messages by moving them under the
errors:section to fix the test cases. It also adds missing keys.